open in new window plugin fix

I found out over the weekend that there were problems with the plugin when users put javascript: type links in the code. I think also that named anchors might have had a problem in IE6. I put lots of “if” clauses in and now the javascript only works for http: type links where the host name is not found in the link.  I am worried that the javascript is now way too complicated and is subject to even more odd breaks.

I got a “broken” vote on the page and a bad vote in the ratings from someone who did not like this and probably tested with IE6. I used to have a setup where I could test with older versions of IE, but it broke when IE7 came out and I don’t use it anymore. I will do a search to see if there is some way to test with IE6.

I am discouraged by this and if I get any more negative feedback I will remove the plugin from the wordpress repository.

Comments 4

  1. DXJ wrote:

    Hello,my friend. What’s wrong? My IE is IE6 and I didn’t find any problem in 1.2. It works well. Now I update to 1.3. I works well too.

    Posted 05 Jan 2010 at 10:19 pm
  2. Keith wrote:

    I had complaints that it did not work with IE6. Someone said it was broken with “object not defined” error, which means that I was trying to access something that was not set correctly. The probable culprits would be named anchors and javascript links with an onClick event and no href. I could not reproduce the error, but the new version works for named anchors, javascript and onclick events for IE 5.5,6,7 and 8 as well as firefox, chrome and safari.

    I have loaded it on my personal blog and nobody is complaining.

    I hope I got the problem.

    Posted 05 Jan 2010 at 10:28 pm
  3. Mark wrote:

    I have installed and activated your “Open in new window” plugin. Just one question, how do I use it? I can’t see any tabs or features to use it.

    Posted 15 Jan 2010 at 12:00 pm
  4. Keith wrote:

    There is nothing to do. The plugin sets any clicks to an external website to a new window. Check it by going to your blog and clicking on an external link.

    Keith

    Posted 15 Jan 2010 at 12:16 pm

Post a Comment

Your email is never published nor shared. Required fields are marked *